Revert "[PERF] Decouple projections from GDN custom op"#28080
Merged
simon-mo merged 1 commit intovllm-project:mainfrom Nov 4, 2025
Merged
Revert "[PERF] Decouple projections from GDN custom op"#28080simon-mo merged 1 commit intovllm-project:mainfrom
simon-mo merged 1 commit intovllm-project:mainfrom
Conversation
vadiklyutiy
requested review from
ProExpertProg,
WoosukKwon,
hmellor,
houseroad,
mgoin,
robertgshaw2-redhat,
sighingnow,
simon-mo,
tlrmchlsmth,
yewentao256 and
youkaichao
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request reverts a previous change that decoupled input/output projections from the GDN custom operation. The changes are consistent across all files, effectively re-integrating the projection logic into the gdn_attention custom op's execution path. The modifications, including renaming the custom op from gdn_attention_core back to gdn_attention and adjusting the related function signatures and logic flow, appear to be a correct and complete revert of the original performance optimization attempt. I have reviewed the changes and found no new issues of high or critical severity introduced by this revert.
…7512) Signed-off-by: Vadim Gimpelson <vadim.gimpelson@gmail.com>
vadiklyutiy
force-pushed
the
revert-27512-vadim/refac-gdn
branch
from
3d3da84 to
fb128a1
Compare
ZhengHongming888
pushed a commit
to ZhengHongming888/vllm
that referenced
this pull request
Nov 8, 2025
…#28080) Signed-off-by: Vadim Gimpelson <vadim.gimpelson@gmail.com>
devpatelio
pushed a commit
to SumanthRH/vllm
that referenced
this pull request
Nov 29, 2025
…#28080) Signed-off-by: Vadim Gimpelson <vadim.gimpelson@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #27512